Meeting notes
Kate edited this page Mar 13, 2024
·
29 revisions
Next weekly meeting: 2024/03/20 14:00 Europe/London time
Present: @kit-ty-kate, @raphael-proust
- Reviewed Kate's draft documenting the current policies of opam-repository. The draft should be published tomorrow alongside a PR rewriting
CONTRIBUTING.md - Merged https://github.com/ocaml/opam-repository/pull/25474
Present: @kit-ty-kate, @raphael-proust
Work on draft of archival-repository proposal
Meeting notes of the fourth public meeting on the future of opam-repository
Present: @kit-ty-kate, @raphael-proust, @mseri
Triage and merging of PRs.
Meeting notes of the third public meeting on the future of opam-repository
Present: @kit-ty-kate, @arbipher
No active maintainers with commit rights was present so instead Kate tried to teach how to review PRs. In doing that:
- the main wiki page was updated
- the review guideline page was updated to the new documentation (there are still some TODO but it's good enough and is up-to-date)
- notes about constraint equality and
dune substwas added
- notes about constraint equality and
- a note about how to create code suggestions (github feature) was added to the onboarding documentation
Meeting notes of the second public meeting on the future of opam-repository
- Discussed afl-persistent issues on macos. Pinged developer. Made a PR to opam-repo to add a patch.
- Discussed lru-cache/lru_cache name collision. Ran local tests. Opened issue on opam-repo-CI. https://github.com/ocurrent/opam-repo-ci/issues/264
- Discussed next-week's meeting to prepare discussions.
Meeting notes of the first public meeting on the future of opam-repository
Notes to be written down later. Note taker got sick
Present: @kit-ty-kate, @mseri, @arbipher
- We would like to take action on the opam-repository scallability discussion and have invited people interested in the topic for a video chat
- Discussed a bit about why OPAMCRITERIA* are changed in opam-repo-ci: it is needed for checking the lower-bounds constraints and is a remanent of the code otherwise
- Discussed a bit of the reason why dune isn’t installed by default in the ocaml/opam images: dune is not a mendatory dependency, many packages do not depend on it at all and we want to check that the list of dependencies each packages lists is accurate and does not use dune without requiring it
- Cleaned-up all the ready for merge PRs
- Discussed a bit the history of OCaml CI
- Planning chrismas break: we will restart meeting from Jan 10, we may plan a meeting next week to discuss https://github.com/ocaml/opam-repository/issues/23789 with some of the interested people
- We updated https://github.com/ocaml/opam-repository/pull/24828 and will check again
- We discussed and updated https://github.com/ocaml/opam-repository/pull/24884 and sent a correction to mybuild https://github.com/ocaml/opam-repository/pull/24937
- We looked at https://github.com/ocaml/opam-repository/pull/24924 and @haochenx is preparing a PR
- We added a question to https://github.com/ocaml/opam-repository/pull/24897
Present: @kit-ty-kate, @mseri, @arbipher
- OCaml 5.1.1 is planned for tomorrow, and the few packages that are not compatible with it should be merged first (batteries, js_of_ocaml and melange)
- What kind of timeframe should the Christmas break for opam-repository maintainers meeting be? Added to the agenda for the next meeting.
- Uploaded some missing soupault archives on https://github.com/ocaml/opam-source-archives/commit/3ed41e137a5cdb943c1b99d163e8b7cb1a42004d
- TODO: do the PR on opam-repository to change the urls
- Looked at the failures in https://github.com/ocaml/opam-repository/pull/24897 which seems to be a sandbox issue on macOS where python is trying to cache compiled python files somewhere where it doesn’t have the right to write files to.
Present: @kit-ty-kate, @haochenx, @mseri, @arbipher
- Discussed the idea of a set-date open meeting for opam-repository to try and get people interested in contributing
- #24841: the patch itself is fine but it looks like a bug in ocamlfind (reported upstream in ocaml/ocamlfind#70)
- opam 2.2.0~alpha brings
opam admin add-constraint --packages=<PACKAGES>which only updates the listed packages. It was used for #24868 - Discussed ocaml/dune#9272: the issue only appears when a package or dependency uses
dune-siteand promotion at the same time so it’s a bit too specific to do anything in opam-repository as it would mean people who are not in this case would be forced to downgrade dune-site or break their local project.
Present: @kit-ty-kate, @arbipher, @mseri
-
https://github.com/ocaml/opam-repository/pull/24772
- Q: Unknown error
# Error: I don't know about package highlexer (passed through --only-packages) - A: Turns out the problem was that the package was trying to be built without any archives (missing
urlsection) - TODO: Add a lint check to opam-repo-ci or opam lint
- Q: Unknown error
-
https://github.com/ocaml/opam-repository/pull/24815
- Discussed what to do with the broken solo5 packages
- The breakage only happens with a certain version of gcc so the most sensible thing to do is to use
x-ci-accept-failures
-
https://github.com/ocaml/opam-repository/issues/24263
- Agreed on modifying the result < 1.5 packages so that they become incompatible with OCaml >= 4.08
-
https://github.com/ocaml/opam-repository/pull/24689
- zarith is a dependency but it seems unused. Instead a vendored version is used
- Some small progress on the documentation writing
Present: @kit-ty-kate, @raphael-proust, @mseri, @arbipher
- Issue triage.
- There are linking issues appearing only in revdeps because in linux the linking is too permissive: it doesn't check that all symbols are defined. E.g., https://github.com/ocaml/opam-repository/pull/24745#issuecomment-1809744599 . No action required, but maintainers need to be aware.
- Discussed removal of
base-unixwhich seem to have no purpose. No action decided yet. We will revisit the question later.
Present: @kit-ty-kate, @raphael-proust, @mseri, @arbipher
- We discussed PR https://github.com/ocaml/opam-repository/pull/24642 and what to do with archives that have disappeared. However the packages of this MR cannot be built on the current CI because of dated packaging. We replaced this PR by one that marks packages as unavailable.
Meeting cancelled
Present: @kit-ty-kate, @haochenx, @raphael-proust, @mseri
- Discussed @kit-ty-kate's draft documentation for the PR review guidelines.
- Some of the checks could be automated if a diff between the previous version of a package and the new one was shown for every PRs
- Discussed #24652
- The purpose of the conf-python-3 (version 9.0.0) is not fulfill as the original author thought that
conf-python-3.9.0.0meant theconf-pythonat the version3.9.0.0However the package is currently not used in this way. There should be a separateconf-python-3-9if absolutely necessary. But mostly to fix this issue properly, opam needs to improve its support of depexts, in particular being able to have version requirements of depexts. See https://github.com/ocaml/opam/issues/2168
- The purpose of the conf-python-3 (version 9.0.0) is not fulfill as the original author thought that
Present: @kit-ty-kate, @haochenx, @raphael-proust, @rikusilvola, @mseri, @arbipher
- Discussed @kit-ty-kate's draft of triaging guidelines. They are now on the wiki.
- We need an "inbox" channel on public platforms for people to ask questions and to notify us about upcoming releases.
Present: @kit-ty-kate, @haochenx, @raphael-proust, @rikusilvola
- Added an agenda (https://github.com/ocaml/opam-repository/wiki/Meetings-agenda) for the meetings so tasks that we should do at the beginning of each meeting are written down and not forgotten
Missing notes
Missing notes
Missing notes
Missing notes
Missing notes
Present: @kit-ty-kate, @haochenx
- None of the newcomers actually had triaging rights on the repository... wtf! (now fixed for haochenx)
- General feedback from newcomer into opam-repository maintenance (haochenx):
- It is unclear what to do as a new maintainer in the general sense in a lot of typical situations. For example the expectation communicated during the onboarding meeting was unclear about what to do in the situation when the newest PRs are already be triaged by someone else (especially what is expected for the new comers so our efforts may provide values for the reporters and other maintainers)
- Actionable: Write a new maintainer's guide
- It would be nice to have feedback as new maintainer
- kit-ty-kate hasn't personally seen any of the new maintainers in the past month, apart from haochenx
- can definitely give feedback when i see an action that doesn't go in the right direction but weekly meeting is more suited for more general feedback and progress tracking
- Idea: show diff with previous version of the new package(s) using a Github Action
- It would be nice to have a status.ci.ocaml.org website
- Have a periodic health job on each server and disable that server if there is a problem
- Actionable: pass that request to the CI team
- It is unclear what to do as a new maintainer in the general sense in a lot of typical situations. For example the expectation communicated during the onboarding meeting was unclear about what to do in the situation when the newest PRs are already be triaged by someone else (especially what is expected for the new comers so our efforts may provide values for the reporters and other maintainers)
Present: @kit-ty-kate, @raphael-proust, @mseri
- Forgot to take notes but it was a usual meeting just dealing with PRs together
- Detected an issue with opam packages < 2.0.6 and https://github.com/ocurrent/opam-repo-ci/pull/210
Present: @kit-ty-kate
- Cancelled due to lack of person present