-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gapi-ocaml 0.4.5 and google-drive-ocamlfuse 0.7.31 #24745
Conversation
f096fb5
to
0c0e119
Compare
Looks like |
Yes, the problem is caused by camlidl 1.11. It should be fixed in version 1.12 that is still not on opam. |
Should we mark camlidl 1.11 as not available on ocaml 5 in the meantime? |
Yes, I think it's a good idea. It needs pull request xavierleroy/camlidl#25 to work with OCaml 5. |
Looks like the release was there already, but never sent here. I opened a PR |
Great! Thanks! |
OK, I'm converting this to draft, because I have to cut another release because I had a test that tried to modify a string. |
Now I have failures only on lower-bounds checks with OCaml 5.0 and 5.1. Is there a way to express different lower bounds for dependencies based on OCaml version? |
If it isn't possible, I think it's good to merge. Thanks! |
@astrada what's the lower bound you're trying to describe? We can try to describe it with a &| formula |
I'd like to set camlidl >= 1.12 if OCaml version >= 5.0 and similarly a version of ocurl that compiles with OCaml >= 5.0. Thanks! |
I need to add lower bounds to previous camlidl versions, then I’ll check ocurl |
Thanks a lot! |
The remaining failures are CI or ocurl issues. The only one still relevant for this package are the multiple failures on macos (all compiler versions). Are these expected?
|
Thanks!
Yes, I imported what I used from ocamlnet to get rid of the dependency that was blocking the upgrade to OCaml 5. I tried to import the minimum code I needed but there is a lot of C that needs autoconf (that I removed to simplify the build) to be cross platform. And I don't have access to a macos box to test the package. So, it's probably smarter to remove macos from the opam file of gapi-ocaml. |
The remaining failures show that we need some bounds on ocurl. I'll do that separately. Thanks We need to postpone merges for some time but once we can merge again later, I'll marge this |
Great! Thanks for your support! |
Thanks, sorry for the wait |
No problem! |
No description provided.