Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package camlimages.5.0.5 #24924

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

camlspotter
Copy link
Contributor

camlimages.5.0.5

Image processing library
An image processing library, which provides loading and saving various image formats with an interface for the Caml graphics library. It has also an interface with the freetype library to draw texts using truetype fonts.



🐫 Pull-request generated by opam-publish v2.3.0

@camlspotter
Copy link
Contributor Author

Checking the CI failures...

@camlspotter
Copy link
Contributor Author

Analysis of CI failures:

  • Old liquidsoap versions: the latest liquidsoap compiles.
  • advi.2.0.0 in OCaml 5.1 : It fails to compile due to the use of deprecated Stdlib.Printexc.catch. Not the issue of camlimages.
  • distributions: linker errors due to lack of -fPIC

Not sure what is the best option to handle these "-fPIC" flags...

Copy link
Collaborator

@haochenx haochenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing concerns me is the revdeps of liquidsoaps. I have created a PR that should fix the failures so please take a look when you have time: camlspotter#2

For the distribution failures I'm afraid that there's not too much thing we can do about. You can look at the x-ci-accept-failures option if you want to reduce CI noises but it's not mandatory.

As you mentioned advi is unrelated to this PR so I don't think you have to do anything about it.

Copy link
Collaborator

@haochenx haochenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like now there are only the distro failures that we cannot do anything about and the advi failure that is not related to this package.

Looks good to me for merging!

@mseri mseri merged commit 6c92248 into ocaml:master Dec 18, 2023
1 of 2 checks passed
@mseri
Copy link
Member

mseri commented Dec 18, 2023

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants