Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch mccs to build on darwin. #3529

Closed
wants to merge 1 commit into from
Closed

Patch mccs to build on darwin. #3529

wants to merge 1 commit into from

Conversation

xplat
Copy link

@xplat xplat commented Sep 4, 2018

@xplat xplat mentioned this pull request Sep 4, 2018
Merged
9 tasks
@rjbou rjbou requested a review from AltGr September 11, 2018 16:54
@rjbou
Copy link
Collaborator

rjbou commented Sep 20, 2018

I think that It's better to have the fix merged on ocaml-mccs and then update opam dependency, instead of having the same fix in two different places.

@samoht samoht mentioned this pull request Sep 26, 2018
Merged
@rjbou rjbou mentioned this pull request Oct 9, 2018
Merged
@rjbou
Copy link
Collaborator

rjbou commented Oct 9, 2018

ocaml-mccs PR was merged and a new version published. The referenced PR updates mccs archive, which is less complex than having to update the patch accordingly.
Thanks!

@rjbou rjbou closed this in #3592 Oct 9, 2018
@rjbou rjbou added this to the 2.0.1 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AltGr AltGr Awaiting requested review from AltGr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@xplat @rjbou