2.0.1 release: backported commits #3560
Conversation
Two sed expressions tidied slightly (better s-separator) but critically a GNU \+ converted to an equivalent (here) POSIX *. Fixes ocaml#3480
Until ocaml/flexdll#52 is resolved, Cygwin64 is essentially a broken platform for OCaml.
|
I'm not sure including #3522 is a good idea - when I (or someone) has a moment to complete that (so that I was porting the build system to dune on the plane yesterday and noticed, for example, that the removal of |
|
Yea, I think it's probably a good idea to just cherry-pick the 3 patches really needed for 2.0.1 -- that would also make easier to review for external eyes :-) |
|
@samoht - that said, the other two (small) commits of mine in the list are worth including! |
|
I went through the list of commits and I've tried to asses their impact / severity. Please check that I haven't done any mistake! Should be included
Ease packaging
Some of them are CI targeted commits. Should be discussed
All the commits related to improving the install scripts should not be included IMHO, unless there is a strong argument in favour. There are a few other commits that I don't think we should include (especially the series of patch breaking and then fixig opam list --external), but appart than that I think the list is ok. What about the issues to compile mccs on OSX (can't find the references) |
|
The mccs issue is ocaml-opam/ocaml-mccs#15 |
|
Ok so ocaml-opam/ocaml-mccs#15 and #3529 have also to be somehow resolved before 2.0.1 Edit: I've added an entry about mccs in my table. |
|
#3572 should probably be added to this list (although they could be shelved for 2.0.2, given that they are essentially cosmetic) |
rjbou
force-pushed
the
2.0
branch
2 times, most recently
from
b70822b
to
d192b30
Compare
|
Last update!
One of the way to install an new version of opam is to use the install script, that contains the archive url & cheksum. I wanted to redirect this time to the install.sh in branch 2.0 instead of putting version change on master branch (which should be at version 2.1.0). |
…caml#3516) Don't continue with checksum check if openssl sha512 is unavailable
During the upgrade process, opam repo files are upgrades to 2.0, but not remaining switch opam files. When pinning a package with opam1.2, an overlay opam file is stored internally. Then, when opam2.0.0 tries to install it, it takes it as is, and some check fail (the availability conditions error). As the process of converting opam files from 1.2 to 2.0 is done at pin, repinning them with opam2.0 unblocks the situation.
If an opam pin --edit concerns an opam file not defining the field name, an error is raised $ opam pin --edit opam-core --dev -n Fatal error: Field 'name:' is required
In order to split `print_depexts st set` into `print_depexts (get_depexts st set)`
Uses OpamFile.Comp.to_package and apply a filter and var rewriting
This reverts commit 3d69c4b.
and do the format upgrade
- add usage OPAM_USER_PATH_RO environement variable for setting unusual pathes in mount bind_ro list - remove some unusual path from the script (/nix/store /rw/usrlocal)
Detection of C++ was skipped if --disable-checks was specified. C++ is now checked unless --without-mccs is passed. If --disable-checks is specified, then the lack of a C++ compiler is not considered a hard error, since we should be assuming the presence of a compiled mccs package.
This had apparently gone through too many iterations! opam will have an internal solver if MCCS_ENABLED is true. If it's false, then configure will have verified that no mccs package was installed and it will also not be included in `make lib-ext`.
New target make -C src_ext has-archives which tests whether src_ext/archives is populated. This test is used by configure and suppresses the error if neither wget nor curl is found.
if variables test and doc are present in the opam file, advise to use with-test and with-doc if it was what user wanted first: opam2 format changed builti-in varibales test and doc to with-test and with-doc.
Output from `opam show` now includes quotes.
As it won't ever be updated!
Requires the addition of the seq compatibility library
Change missing from 5861ee3.
This PR contains commits to be backported to the release 2.0.1. We want to release it quickly (next week ?), to have these fixes into distribution packages.
I kept all fixes but we should just keep critical ones?
imho, most critical are:
opam showthat don't return update 2.0 fileopam list --silentthat reintroduce a return code if the list is emptyNote: I kept extract error enhancement because openbsd tar fix relies on it (conflict).
cc @AltGr @dra27 @samoht @avsm