OCaml 5.0 support #5357
Merged
OCaml 5.0 support #5357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
reviewed
Nov 18, 2022
rjbou
reviewed
Nov 18, 2022
Dose_algo.Depsolver.check_request_using actually never used its ~criteria argument(!!) 🤯
rjbou
reviewed
Dec 5, 2022
rjbou
reviewed
Dec 5, 2022
|
Is there a way to have base 64 compatibility handling in patches or in |
rjbou
approved these changes
Dec 5, 2022
|
Discussing that, there is no other way, it won't go on master. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5354 on 2.1
Cherry-picks key commits from #4760 and #5355