Fix dune subdir stanza syntax highlighting

[SaySayo]

Fixes (#864)

[tmattio]

Thanks @SaySayo 🙂

The subdir stanza works by evaluating the dune stanza in a subdirectory. So it should support every dune stanza, not only the rule one. To do this I think we can extract all the patterns in a scope, and include this in the subdir patterns (assuming the textmate grammar support recursivity).

[SaySayo]

That's a great idea! I'll do that now

[SaySayo]

That's a great idea! I'll do that now

[mnxn]

The subdir stanza works by evaluating the dune stanza in a subdirectory. So it should support every dune stanza, not only the rule one. To do this I think we can extract all the patterns in a scope, and include this in the subdir patterns (assuming the textmate grammar support recursivity).

I think extracting all of the patterns into a new scope is actually unnecessary. You can make the patterns of subdir include $self and that should highlight everything

I believe this should work:

"comment": "subdir",
"begin": "\\([[:space:]]*(subdir)\\b",
"end": "\\)",
"beginCaptures": {
  "1": {
    "name": "keyword.language.dune"
  }
},
"patterns": [{ "include": "$self" }]

[mnxn]

Thanks!