Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dune's rule stanza in subdir is not highlighted properly #864

Closed
tmattio opened this issue Feb 14, 2022 · 3 comments · Fixed by #870
Closed

Dune's rule stanza in subdir is not highlighted properly #864

tmattio opened this issue Feb 14, 2022 · 3 comments · Fixed by #870
Labels
type: bug Something isn't working
Milestone

Comments

@tmattio
Copy link
Collaborator

tmattio commented Feb 14, 2022

The following dune code doesn't seem to be highlighted properly with VSCode 1.9.0:

(subdir
 asset/
 (rule
  (target main.css)
  (deps
   (:data ../tailwind.config.js ../postcss.config.js)
   (source_tree ../node_modules)
   (source_tree ../src/ocamlorg_frontend))
  (action
   (chdir
    %{workspace_root}
    (run
     node
     node_modules/postcss-cli/index.js
     src/ocamlorg_frontend/css/styles.css
     -o
     %{target})))))

image

cc @SaySayo

@tmattio tmattio added the type: bug Something isn't working label Feb 14, 2022
@SaySayo
Copy link
Contributor

SaySayo commented Feb 14, 2022 via email

@SaySayo
Copy link
Contributor

SaySayo commented Feb 14, 2022

Screenshot 2022-02-14 at 20 06 28

@tmattio I just made these changes. Are these good now?

@tmattio
Copy link
Collaborator Author

tmattio commented Feb 14, 2022

@SaySayo that looks great! Feel free to open a PR with your patch 🙂

@mnxn mnxn linked a pull request Feb 18, 2022 that will close this issue
@mnxn mnxn closed this as completed Feb 18, 2022
@rgrinberg rgrinberg added this to the 1.9.2 milestone Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants