Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Loading Data Prompt #29

Closed
skarphet opened this issue Sep 19, 2016 · 2 comments
Closed

Loading Data Prompt #29

skarphet opened this issue Sep 19, 2016 · 2 comments
Labels

Comments

@skarphet
Copy link

skarphet commented Sep 19, 2016

Would be useful with a loading data prompt - we just had a 2 hour operation with 70~ players and the JSON takes a while to load. It just makes the screen go blank.

I'll try to send a pull request for this within a day or two. It may have been added already but I haven't seen it yet, at least.

@skarphet
Copy link
Author

Looking at ocap.js, I found the following: https://github.com/mistergoodson/OCAP/blob/master/web/scripts/ocap.js#L872-L876

However, this modal never actually appears to be visible or it is the main modal and it simply disappears right after clicking, kind of defeating the point. Is this intended design?

@JamieGoodson
Copy link
Collaborator

JamieGoodson commented Sep 19, 2016

Good spot. The modal is supposed to display that message, then hide it after processOp is complete. However, since processOp is asynchronous, it hides the message almost immediately after showing it. I've modified the script to now display this correctly (see 361bcaa).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants