Draft OCapN netlayers specification #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dpwiz
reviewed
Aug 6, 2023
|
I'm just wondering if everyone's had a chance to look at this and if there is any more feedback? |
|
I have had a chance to review, but have not :). If you'd like to hear from particular reviewers please make them a reviewer or assignee on the PR. A good way to make sure everyone reads is to put some kind of action of decision on the agenda for an upcoming meeting that requires prior review. |
Closed
dckc
reviewed
Sep 12, 2023
| important and worth noting that the designator and transport alone MUST be | ||
| enough to differenciate between two locations, hints are not used for that. | ||
|
|
||
| # Tor Onion Netlayer |
There was a problem hiding this comment.
I don't see enough detail about the Tor netlayer to implement it.
dckc
reviewed
Sep 12, 2023
|
Based on the approval in #82, I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.