Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated output on rmPreProcessing? #22

Closed
wleoncio opened this issue Jul 9, 2020 · 4 comments
Closed

Duplicated output on rmPreProcessing? #22

wleoncio opened this issue Jul 9, 2020 · 4 comments

Comments

@wleoncio
Copy link
Member

wleoncio commented Jul 9, 2020

Summary

The output from the README example seems to yield duplicate output.

Script

library(CellMigRation) 
     
data(TrajectoryDataset) 
df <- CellMig(TrajectoryDataset[1:100, ]) 
preproc <- rmPreProcessing(df, PixelSize = 1.24, TimeInterval = 100)     

Observed output

image

Expected output

Only one line starting with "This dataset contains".

Proposed solutions

  1. Delete line 3718 or line 3735
  2. Improve messages so output is clearer to user (e.g. add "also contains" to L3735)
@SystemsBiologist
Copy link
Collaborator

Hi Waldir,
The TimeInterval is 10 not 100.
In this dataset the duplicated output is meaningless but if we take the output of the tracking from Damiano's part and run the preprocessing then the output will not be duplicated because first the function will exclude the cells with less than three steps but of course if you think it is not important to show the total number of cells in the dataset we can remove the first line and keep the second.

@wleoncio
Copy link
Member Author

wleoncio commented Jul 9, 2020

So maybe the first line should say "This dataset contains: 1 Cell in total"? I think this differentiates that content from the one on the second line well enough.

@SystemsBiologist
Copy link
Collaborator

I totally agree.

@wleoncio
Copy link
Member Author

wleoncio commented Jul 9, 2020

Solved on 4e430c1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants