Fixed libobs case in FindLibObs.cmake #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you able to test in osx and Windows? It's ok if you can't. I think this is anyway a good change. I'll merge later. Thanks for the contribution |
royshil
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Add obs-plugintemplate files (#1) * Add obs-plugintemplate files * Rename * Update CMakeLists.txt * Update main.yml * files * Update CMakeLists.txt * Fix * Update .Brewfile * Update main.yml * Update main.yml * check-cmake.sh * Update main.yml * Update main.yml * Build my opencv (#2) * BuildMyOpenCV.cmake * Update BuildMyOpenCV.cmake * Update BuildMyOpenCV.cmake * Update BuildMyOpenCV.cmake * Update BuildMyOpenCV.cmake * check-cmake * Update main.yml * Update buildspec.json * Update CMakeLists.txt * Build my onnxruntime (#3) * fix * Update BuildMyOnnxruntime.cmake * Enable arm64 * 0.5.2 * Update BuildMyOnnxruntime.cmake * Update .Brewfile * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * fix * Fix * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * a * Create .gitmodules * Create onnxruntime * Update onnxruntime * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * fix * Update BuildMyOnnxruntime.cmake * ARCHITECTURE * Apply * Update BuildMyOnnxruntime.cmake * fix * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * aaa * Enable Windows build (#4) * Enable Windows build * Update main.yml * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Fix linkage * Remove /WX * Update ObsPluginHelpers.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update CMakeLists.txt * Fix * Update CMakeLists.txt * a * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Disable DML * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update background-filter.cpp * Update BuildMyOnnxruntime.cmake * Disable DML * Fix segfault (#6) * Update Model.h * 0.5.6 * Ccache macos (#8) * Ccache * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Revert "Update BuildMyOnnxruntime.cmake" This reverts commit 44d9caa. * Revert "Update BuildMyOnnxruntime.cmake" This reverts commit 9294106. * Direct ml (#7) * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt * dml * 0.5.7 * Update CMakeLists.txt * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * a * Update main.yml * Update BuildMyOnnxruntime.cmake * Update main.yml * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Fix * Update BuildMyOnnxruntime.cmake * Update main.yml * Linux build (#9) * linux * 0.5.8 * Update BuildMyOnnxruntime.cmake * Update setup_ccache (#10) * bump version (#11) * Use ninja on windows (#12) * Update main.yml * Update main.yml * Use Ninja * Update BuildMyOnnxruntime.cmake * Update main.yml * ccache * Update BuildMyOpenCV.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update BuildMyOnnxruntime.cmake * Update main.yml * Update main.yml * Update CMakeLists.txt * Update BuildMyOnnxruntime.cmake * Long path * Update main.yml * Update BuildMyOnnxruntime.cmake * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Update BuildMyOnnxruntime.cmake * Windows opencv ccache (#13) * Update BuildMyOpenCV.cmake * Update BuildMyOpenCV.cmake * Update BuildMyOpenCV.cmake * Update BuildMyOpenCV.cmake * Update BuildMyOpenCV.cmake * Update BuildMyOpenCV.cmake * Update BuildMyOpenCV.cmake * Update main.yml * Update BuildMyOpenCV.cmake * bump 0.5.10 (#14) * Cleanup (#15) * Cleanup * bump version * Fix ep (#16) * Update BuildMyOnnxruntime.cmake * Update BuildMyOpenCV.cmake * Update main.yml (#18) * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * 0.5.12 * Fix * Update package-macos.zsh * Update package-linux.zsh * Update CMakeLists.txt * ci * Fix * Update background-filter.cpp * Fix * clang-format * cmake-format * Update BuildMyOpenCV.cmake * Update BuildMyOnnxruntime.cmake * Fix errors * Use -isystem * Use list in set_target_properties * INTERFACE_INCLUDE_DIRECTORIES must be on IMPORTED TARGET * Update ObsPluginHelpers.cmake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids this warning in cmake .. on fedora33:
CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:426 (message):
The package name passed to
find_package_handle_standard_args(Libobs)does not match the name of the calling package (LibObs). This can lead to
problems in calling code that expects
find_packageresult variables(e.g.,
_FOUND) to follow a certain pattern.