Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srt subtitles file saving and source mute detection #36

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

royshil
Copy link
Collaborator

@royshil royshil commented Oct 7, 2023

No description provided.

@royshil royshil changed the title srt subtitles file saving srt subtitles file saving and source mute detection Oct 9, 2023
@royshil royshil added the help wanted Extra attention is needed label Oct 9, 2023
@royshil royshil requested a review from umireon October 10, 2023 02:00
@royshil
Copy link
Collaborator Author

royshil commented Oct 10, 2023

@umireon are you able to test this quick and approve? 🙏

@umireon
Copy link
Member

umireon commented Oct 10, 2023

@royshil Can you add the Seeking Testers label?

@royshil
Copy link
Collaborator Author

royshil commented Oct 10, 2023

@umireon i added but the label doesn't affect CI right now in this project, I believe

@umireon
Copy link
Member

umireon commented Oct 10, 2023

I will make a PR containing various fixes for CI pipelines first. This will include the fix to have the Seeking Testers label work.

@umireon
Copy link
Member

umireon commented Oct 10, 2023

Opened #37

@royshil royshil mentioned this pull request Oct 10, 2023
@umireon
Copy link
Member

umireon commented Oct 11, 2023

@royshil Can you update this branch to master?

Copy link
Member

@umireon umireon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@royshil royshil merged commit b21a42a into master Oct 12, 2023
6 checks passed
@royshil royshil deleted the roy.srt_output_muted_disable branch October 12, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Seeking Testers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants