Downcase email on registration

[lefnire]

Emails currently case-sensitive. Either downcase on registration or on lookup.

[matt-stanley]

Please see Pull Request #18 addressing this issue. Thank you.

[lefnire]

Merged and will use. Gonna keep open for now in case we find an easy server-side solution. If it's a doozie, we'll just use this solution and expect all API-consumers to do the same.

[tullur]

Hi! I'll try to do server-side solution.

[tullur]

Hm, I have two solutions for this problem.

1. Use sqlalchemy validates decorator. Example:

@validates('email')
def validate_email(self, key, value):
    return value.lower()

2. Use the text construct. Example:

from sqlalchemy.sql.expressions import text

class User(Base, SQLAlchemyBaseUserTable):
    __tablename__ = 'user'
    __table_args__ = (
        Index('ix_user_email', text('LOWER(email)')), 
    )

What would be better?

[lefnire]

Ah, your (1) looks indeed like what they were after in fastapi-users/fastapi-users#245. Actually I totally missed that version 3, while storing emails case-sensitive, looks them up insensitive https://frankie567.github.io/fastapi-users/migration/2x_to_3x/ (linked in that ticket). Looks like we're actually good on this

Great minds though @tullur , you were barking up the right tree good job!

[lefnire]

Either way, @matt-stanley's client-side solution (which I've tested & pushed) makes it obvious to the user, so client + server good now. Thanks guys!