Move away from onig to regex

[untitaker]

Would you accept a patch that moves from onig to regex for performance? The go implementation uses a similar regex dialect and it seems that the uap-core project made their regexes compatible with that.

[untitaker]

@davidarmstronglewis

[untitaker]

nvm rust-lang/regex#524

[untitaker]

checking if it's feasible to change the regexes in uap-core to avoid ||

[oceanlewis]

You can definitely take a look, but if you're looking for a pure Rust implementation this project might not be the best for your use-case since I am relying on upstream regexes from the UAParser project. I suppose there's nothing stopping you from supplying your own regexes and swapping out the Onig for Regex, but at that point you're probably better off looking at Woothie.

[untitaker]

I was looking into upstreaming fixes to uaparser that make it possible to parse the regexes with the regex crate, but that seems like a monumental task now. Older versions of regexes.yaml work fine.

…

On 26.08.2019, at 20:28, David Lewis ***@***.***> wrote: You can definitely take a look, but if you're looking for a pure Rust implementation this project might not be the best for your use-case since I am relying on upstream regexes from the UAParser project. I suppose there's nothing stopping you from supplying your own regexes and swapping out the Onig for Regex, but at that point you're probably better off looking at Woothie. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[oceanlewis]

Thanks for looking into this. Let me know if you decide to keep going with this library or move to another :)

[untitaker]

I stopped putting time into this, the status quo is that we use this library despite onig. For our WASM builds we have disabled the functionality that requires user agent parsing.

…

On 27.08.2019, at 23:00, David Lewis ***@***.***> wrote: Thanks for looking into this. Let me know if you decide to keep going with this library or move to another :) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[untitaker]

#4 moves the library to fancy-regex