Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt pandas Timestamps #43

Open
brey opened this issue Aug 23, 2022 · 2 comments
Open

Adopt pandas Timestamps #43

brey opened this issue Aug 23, 2022 · 2 comments

Comments

@brey
Copy link
Contributor

brey commented Aug 23, 2022

searvey/searvey/ioc.py

Line 274 in 7e822c1

endtime: Union[str, datetime.date] = datetime.date.today(),

Setting datetime.date above overlooks the hours component. I suggest we use pandas Timestamps for more flexibility.
@pmav99
Copy link
Member

pmav99 commented Aug 24, 2022

No problem with using the hours, too. Nevertheless we must ensure that the timestamps are in UTC.

@brey
Copy link
Contributor Author

brey commented Sep 3, 2023

I think this is resolved with #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pmav99 @brey