Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme Improvements #92

Closed
jamiehewitt15 opened this issue Apr 20, 2021 · 0 comments · Fixed by #93 or #100
Closed

Readme Improvements #92

jamiehewitt15 opened this issue Apr 20, 2021 · 0 comments · Fixed by #93 or #100
Labels
Type: Enhancement New feature or request

Comments

@jamiehewitt15
Copy link
Member

jamiehewitt15 commented Apr 20, 2021 •
edited
Loading

Readme needs to be made clearer in a few places, particularly around testing:

  • npm run test command doesn't work
  • Running export ADDRESS_FILE="${HOME}/.ocean/ocean-contracts/artifacts/address.json" in the same terminal as the test commands
  • Cloning Barge
  • Making sure most up to date version of barge is used
@jamiehewitt15 jamiehewitt15 added the Type: Bug Something isn't working label Apr 20, 2021
@jamiehewitt15 jamiehewitt15 changed the title Wrong command in Readme Readme Improvements Apr 21, 2021
@jamiehewitt15 jamiehewitt15 added Type: Enhancement New feature or request and removed Type: Bug Something isn't working labels Apr 21, 2021
@jamiehewitt15 jamiehewitt15 mentioned this issue Apr 21, 2021
Merged
@jamiehewitt15 jamiehewitt15 reopened this May 4, 2021
@jamiehewitt15 jamiehewitt15 mentioned this issue May 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@jamiehewitt15