Added custody light README. #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
calina-c
requested changes
Feb 15, 2023
ocean_lib/ocean/ocean_assets.py
Outdated
| @@ -342,8 +343,17 @@ def create_bundled( | |||
| name = metadata["name"] | |||
| template_index = 2 if use_enterprise else 1 | |||
| data_nft_args = DataNFTArguments(name, name) | |||
| datatoken_args = DatatokenArguments( | |||
| f"{name}: DT1", files=files, template_index=template_index | |||
| datatoken_args = ( | |||
There was a problem hiding this comment.
I think you should assign this previously and simplify.
e.g. dt_args=DatatokenArguments(
f"{name}: DT1", files=files, template_index=template_index
)
if template_index == 2:
dt_args.cap=MAX_UINT256
maybe the init part itself has the exception, but either way this needs to be cleaner
There was a problem hiding this comment.
Added an assignment before initializing the DatatokenArguments object
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
temporarily deployed
to
CC_REPORTER_ID
GitHub Actions
Inactive
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
temporarily deployed
to
CC_REPORTER_ID
GitHub Actions
Inactive
mariacarmina
temporarily deployed
to
CC_REPORTER_ID
GitHub Actions
Inactive
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
had a problem deploying
to
CC_REPORTER_ID
GitHub Actions
Failure
mariacarmina
temporarily deployed
to
CC_REPORTER_ID
GitHub Actions
Inactive
mariacarmina
temporarily deployed
to
CC_REPORTER_ID
GitHub Actions
Inactive
calina-c
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1300 .
Changes proposed in this PR: