Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throttle goes beyond 100% #42

Closed
xxxyyyqqq12345 opened this issue Jan 25, 2019 · 2 comments
Closed

Throttle goes beyond 100% #42

xxxyyyqqq12345 opened this issue Jan 25, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@xxxyyyqqq12345
Copy link
Contributor

Throttle can go beyond 100%
@xxxyyyqqq12345 xxxyyyqqq12345 added the bug Something isn't working label Jan 25, 2019
@pmelanson
Copy link
Member

Technically, in legacy orbit throttle has no upper or lower limit (!)

But that's not realistic, I'll cap throttle at 120%, which is above the safe, nominally rated output of the engine but not high enough to be silly

pmelanson added a commit that referenced this issue Jan 26, 2019
@pmelanson
#42 Bound throttle to [-20%, 120%]
401cd32
@pmelanson
Copy link
Member

Should be fixed with 401cd32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pmelanson @xxxyyyqqq12345