Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use module: node12 in tsconfig.json; supports not transpiling import() / dynamic import for CommonJS code #256

Closed
typhonrt opened this issue Sep 25, 2021 · 2 comments · Fixed by #750
Labels
enhancement New feature or request ESM Related to ESM support

Comments

@typhonrt
Copy link
Contributor

typhonrt commented Sep 25, 2021

A most recent merged PR for Typescript now better supports Node 12. In particular there is no need for the "semi-hack" used in module-loader.ts.

You can see discussion here and the PR here. When the latest Typescript version is available w/ this PR I'll look into adding module: node12 to tsconfig.json and verify that import dynamic works correctly with the Oclif core build and remove the workaround.

A blog post about the Typescript 4.5 beta.

@mdonnalley
Copy link
Contributor

@typhonrt Is this work that you're still interested in doing? Or can we close this?

@git2gus
Copy link

git2gus bot commented Jul 26, 2023

This issue has been linked to a new work item: W-13832724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ESM Related to ESM support
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

2 participants