Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise is not rejected if file load fails #66

Closed
gusmanb opened this issue Sep 23, 2014 · 1 comment
Closed

Promise is not rejected if file load fails #66

gusmanb opened this issue Sep 23, 2014 · 1 comment
Labels

Comments

@gusmanb
Copy link

gusmanb commented Sep 23, 2014

When dynamically loading a module, if the js load fails the promise is not rejected and the application can get blocked.

In line 320 change:
$q.all(deferredList).then(function() { deferred.resolve(module); });

to

$q.all(deferredList).then(function() { deferred.resolve(module); }, function() { deferred.reject(); } );

Cheers.

@ocombe
Copy link
Owner

ocombe commented Sep 23, 2014

Oh damn I missed this, thanks, I'll update it tomorrow !

@ocombe ocombe added the bug label Sep 23, 2014
@ocombe ocombe closed this as completed in d83f52b Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants