-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to specify cluster_id without prefix #88
Comments
We can just use cluster_id if cluster_id_prefix is not defined, and do not add "-" in front of cluster_id. |
ltccci
added a commit
that referenced
this issue
Mar 16, 2021
Support specify cluster_id without prefix, Fix #88
yussufsh
pushed a commit
to yussufsh/ocp4-upi-powervm
that referenced
this issue
Apr 8, 2021
Signed-off-by: CS Zhang <zhangcho@us.ibm.com>
yussufsh
pushed a commit
to yussufsh/ocp4-upi-powervm
that referenced
this issue
Apr 12, 2021
Signed-off-by: CS Zhang <zhangcho@us.ibm.com>
yussufsh
pushed a commit
to yussufsh/ocp4-upi-powervm
that referenced
this issue
Apr 12, 2021
Signed-off-by: CS Zhang <zhangcho@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current implementation of user-defined cluster_id (#68) looks a bit not totaly achieved to me (but it is maybe just for me...)
In all openshift documentation,
cluster_id
is a subdomain.API: api.<cluster_id>. ex: api.mycluster.mydomain.org
applications: .apps.<cluster_id>. ex portal.apps.mycluster.mydomain.org
With the current implementation #69 you can't really specify your cluster_id ... it is still a concatenation of
cluster_id
,cluster_prefix
.... (with a - in between).I think it could be good to let the user been able to choose its cluster name (without "-")
your thoughts?
The text was updated successfully, but these errors were encountered: