-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specify cluster_id without prefix, Fix #88 #187
Conversation
Signed-off-by: CS Zhang <zhangcho@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
As cluster_id_prefix
has a default value of "test-ocp", user will always need to explicitly set this to "" to truly use this cluster_id only feature.
@cs-zhang We will need same change in powervs and kvm projects once this is merged. Thanks. |
better to document this in the variables file itself to avoid any confusion |
Signed-off-by: CS Zhang <zhangcho@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpradipt, cs-zhang, yussufsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Just use cloud_id if cloud_id_prefix is not set.
Signed-off-by: CS Zhang zhangcho@us.ibm.com