Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix-side exported interfaces are unsound #2

Closed
Drup opened this issue Apr 18, 2016 · 1 comment
Closed

Mix-side exported interfaces are unsound #2

Drup opened this issue Apr 18, 2016 · 1 comment

Comments

@Drup
Copy link
Member

Drup commented Apr 18, 2016

Let's consider a .cmi exporting this api:

val f : unit -> Dom.t Fragment.t

If this is loaded by vanilla ocaml Dom.t will not be considered client, and the symbol might not even exist. Fragment.t should still be a black box, though.

@vouillon proposed to emit a different magic for such cmi.

@Drup
Copy link
Member Author

Drup commented Apr 27, 2016

This is now done (by, indeed, emitting cmi files with different magic).

@Drup Drup closed this as completed Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant