Lib: add message event types and PerformanceObserver #1164
Conversation
|
The checks failed on MacOS, but I highly doubt that has anything to do with this PR, so my guess is that the build is just flaky. In response to the suggestion to bind supportedEntryTypes, I'd rather not, because I haven't actually used that API in anything, so writing the binding would probably be untested. This current patch is just lifted from an app, so I'm pretty confident that the bindings are done correctly. |
| -> performanceObserver Js.t) | ||
| Js.constr | ||
|
|
||
| val is_supported : unit -> bool |
There was a problem hiding this comment.
i wonder if is_supported should be baked in, or left to user space? genuine ask, not a passive challenge :)
There was a problem hiding this comment.
sorry, it's a quirky phrase :)
baked in: incorporate something as an integral part of a product, service, or system.
one may observe that https://developer.mozilla.org/en-US/docs/Web/API/PerformanceObserver/isSupported doesn't exist. thus, i am asking "should jsoo decorate web apis with extra functions, methods, or properties?"
There was a problem hiding this comment.
I've included is_supported for consistency with the existing intersectionObserver and resizeObserver APIs. One could quite reasonably argue that jsoo should just expose web APIs and nothing more, and I might even agree with it. However, I think this PR does the correct thing by following the existing convention.
pmwhite
force-pushed
the
master
branch
2 times, most recently
from
0f3ef3d
to
04ef5d4
Compare
…s_of_ocaml-ppx_deriving_json, js_of_ocaml-ppx, js_of_ocaml-lwt and js_of_ocaml-compiler (4.0.0) CHANGES: ## Features/Changes * Compiler: add --target-env flag, for JS runtime specific compilation targets (ocsigen/js_of_ocaml#1160). * Compiler: static evaluation of backend_type (ocsigen/js_of_ocaml#1166) * Compiler: speedup emitting js files (ocsigen/js_of_ocaml#1174) * Compiler: simplify (a | 0) >>> 0 into (a >>> 0) (ocsigen/js_of_ocaml#1177) * Compiler: improve static evaluation of cond (ocsigen/js_of_ocaml#1178) * Compiler: be more consistent dealing with js vs ocaml strings (ocsigen/js_of_ocaml#984) * Compiler: Compiler: add BigInt to provided symbols (fix ocsigen/js_of_ocaml#1168) (ocsigen/js_of_ocaml#1191) * Compiler: use globalThis, drop joo_global_object ocsigen/js_of_ocaml#1193 * Compiler: new -Werror flag to turn wanrings into errors (ocsigen/js_of_ocaml#1222) * Compiler: make the inlining less agressive, reduce size, improve pref (ocsigen/js_of_ocaml#1220) * Compiler: rename internal library js_of_ocaml-compiler.runtime to js_of_ocaml-compiler.runtime-files * Lib: new runtime library to improve compatibility with Brr and gen_js_api * Lib: add messageEvent to Dom_html (ocsigen/js_of_ocaml#1164) * Lib: add PerformanceObserver API (ocsigen/js_of_ocaml#1164) * Lib: add CSSStyleDeclaration.{setProperty, getPropertyValue, getPropertyPriority, removeProperty} (ocsigen/js_of_ocaml#1170) * Lib: make window.{inner,outer}{Width,Height} non-optional * Lib: introduce Js_of_ocaml.Js_error module, deprecate Js_of_ocaml.Js.Error exception. * Lib: add deprecation warning for deprecated code * PPX: json can now be derived for mutable records (ocsigen/js_of_ocaml#1184) * Runtime: use crypto.getRandomValues when available (ocsigen/js_of_ocaml#1209) * Misc: move js_of_ocaml-ocamlbuild out to its own repo * Misc: add support for OCaml 4.14 (ocsigen/js_of_ocaml#1173) ## Bug fixes * Compiler: fix sourcemap warning for empty cma (ocsigen/js_of_ocaml#1169) * Compiler: Strengthen bound checks. (ocsigen/js_of_ocaml#1172) * Compiler: fix `--wrap-with-fun` under node (ocsigen/js_of_ocaml#653, ocsigen/js_of_ocaml#1171) * Compiler: fix parsing of annotaions in js stubs (ocsigen/js_of_ocaml#1212, fix ocsigen/js_of_ocaml#1213) * Ppx: allow apostrophe in lident (fix ocsigen/js_of_ocaml#1183) (ocsigen/js_of_ocaml#1192) * Runtime: fix float parsing in hexadecimal form * Runtime: fix implementation of caml_js_instanceof * Graphics: fix mouse_{x,y} (ocsigen/js_of_ocaml#1206)
This is re-opened version of #1123 to fix the bad state that I got the repo into. Sorry for the extra noise.