Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configure.ml #700

Closed
aantron opened this issue Aug 4, 2019 · 3 comments
Closed

Remove configure.ml #700

aantron opened this issue Aug 4, 2019 · 3 comments
Labels
Milestone

Comments

@aantron
Copy link
Collaborator

aantron commented Aug 4, 2019

In favor of passing options directly to the new discover.ml. See #699.

@aantron aantron added this to the 5.0.0 milestone Aug 4, 2019
@aantron
Copy link
Collaborator Author

aantron commented Aug 20, 2019

Usage information for the new discover.ml is found in its code:

This program tries to detect everything automatically. If it is not behaving
correctly, its behavior can be tweaked by passing it arguments. There are
three ways to do so:
- By editing [src/unix/dune], to pass arguments to [discover.exe] on the
command line.
- By setting the environment variable [LWT_DISCOVER_ARGUMENTS]. The syntax
is the same as the command line.
- By writing a file [src/unix/discover_arguments]. The syntax is again the
same as the command line.
The possible arguments can be found by running
{v
dune exec src/unix/config/discover.exe -- --help
v}
In addition, the environment variables [LIBEV_CFLAGS], [LIBEV_LIBS],
[PTHREAD_CFLAGS], and [PTHREAD_LIBS] can be used to override the flags used
for compiling with libev and pthreads.
This [discover.ml] was added in Lwt 4.3.0, so if you pass arguments to
[discover.ml], 4.3.0 is the minimal required version of Lwt.

@aantron
Copy link
Collaborator Author

aantron commented Aug 21, 2019

configure.ml will be deleted in Lwt 5.0.0, which is to be released around November 2019. It is subsumed by the newly improved discover.ml, which was released just now in Lwt 4.3.0.

If you are using configure.ml, see the new discover.ml usage for how to pass arguments to the configuration process:

This program tries to detect everything automatically. If it is not behaving
correctly, its behavior can be tweaked by passing it arguments. There are
three ways to do so:
- By editing [src/unix/dune], to pass arguments to [discover.exe] on the
command line.
- By setting the environment variable [LWT_DISCOVER_ARGUMENTS]. The syntax
is the same as the command line.
- By writing a file [src/unix/discover_arguments]. The syntax is again the
same as the command line.
The possible arguments can be found by running
{v
dune exec src/unix/config/discover.exe -- --help
v}
In addition, the environment variables [LIBEV_CFLAGS], [LIBEV_LIBS],
[PTHREAD_CFLAGS], and [PTHREAD_LIBS] can be used to override the flags used
for compiling with libev and pthreads.
This [discover.ml] was added in Lwt 4.3.0, so if you pass arguments to
[discover.ml], 4.3.0 is the minimal required version of Lwt.

If you switch to the new process, you have to use Lwt >= 4.3.0.

cc @fdopen, @toots, @whitequark, in case this is relevant for your cross-compilation repos.

@toots
Copy link

toots commented Aug 22, 2019

Hi! Thanks for the heads up. As far as I can tell we are compiling using the dune mechanism without much change except passing -x windows so, so far, it looks fine on my end (windows cross-compilation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants