Rewrite discover.ml #699
Merged
Rewrite discover.ml #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current
discover.mlis pretty confusing. In addition, we have a separateconfigure.mlfor passing options to it, but which also does some discovery. This PR cleans the situation up.discover.ml. I keptconfigure.mlaround for compatibility, and will open an issue about removing it in 5.0.0.discover.mlis reorganized, with a big comment on top. It should now be much easier to add feature tests.cc @XVilka After I merge this, I'll post some links in #696 directly to what you can edit to add features tests :)