Add a ?fd argument to Lwt_io.{open_connection,with_connection,establish_... #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh_server}. The rationale is that one might want to perform sockopts to the sockets created by those functions. They should therefore not internally create a file descriptor for their underlying socket without presenting a way for the user to do sockopts on them. This patch makes it possible to provide a fd to use instead of creating a new one, fixing this issue without changing the current interface.
|
Very useful! |
ghost
pushed a commit
that referenced
this pull request
Aug 11, 2014
Add a ?fd argument to Lwt_io.{open_connection,with_connection,establish_...
ghost
merged commit 
|
Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...server}.
The rationale is that one might want to perform sockopts to the
sockets created by those functions. They should therefore not
internally create a file descriptor for their underlying socket
without presenting a way for the user to do sockopts on them. This
patch makes it possible to provide a fd to use instead of creating a
new one, fixing this issue without changing the current interface.