Skip to content
This repository has been archived by the owner on Aug 21, 2022. It is now read-only.

This "polyfill" is massively uncompliant with the actual spec #3

Closed
domenic opened this issue May 9, 2014 · 3 comments
Closed

This "polyfill" is massively uncompliant with the actual spec #3

domenic opened this issue May 9, 2014 · 3 comments

Comments

@domenic
Copy link

domenic commented May 9, 2014

To test compliance with the ES6 promises spec, run the Promises/A+ test suite, since ES6 promises are a superset of it.

Just looking through the code I found several major spec violations.

Nobody should ever use this library as-is.
@Octane
Copy link
Owner

Octane commented May 9, 2014

This polyfill copies the behavior of built-in Promise in Crome and Firefox.
Errors will be corrected, it is only the first release.

@Octane Octane closed this as completed May 10, 2014
@domenic
Copy link
Author

domenic commented May 10, 2014

You should be running the Promises/A+ tests. There are still several spec violations.

@Octane
Copy link
Owner

Octane commented May 10, 2014

Yes, will test soon.
Thanks for the comments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Octane @domenic