Job 170: add context to the mails for subscribers #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/package.json
Outdated
| @@ -43,7 +44,7 @@ | |||
| "sequelize": "^4.4.4", | |||
| "sequelize-cli": "^2.8.0", | |||
| "serve-favicon": "~2.4.3", | |||
| "sqlite3": "^3.1.9" | |||
| "sqlite3": "^3.1.13" | |||
There was a problem hiding this comment.
Bien !
mais pourquoi ?
There was a problem hiding this comment.
Ah merde, c'est parce que j'ai dû installer sqlite3 pour faire marcher l'appli, c'était cassé...
Mais pourtant je n'avais pas fait de --save...
On garde ou pas ?
trollepierre
approved these changes
Nov 28, 2017
| @@ -11,7 +12,8 @@ module.exports = { | |||
| template += `${addedJobs.length} nouvelle(s) mission(s) à staffer :`; | |||
| template += '<ul>'; | |||
| addedJobs.forEach((job) => { | |||
| template += `<li><bold>${job.activity.title}</bold> pour le projet ${job.project.name}</li>`; | |||
| const formatedDate = moment(job.activity.staffing_needed_from).format('DD/MM/YYYY'); | |||
| template += `<li><bold>${job.activity.title}</bold> pour le projet ${job.project.name} pour le client ${job.project.customer.name} à partir du ${formatedDate}</li>`; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat #170