Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeater maxItems bug #5533

Closed
GinoPane opened this issue Mar 15, 2021 · 1 comment
Closed

Repeater maxItems bug #5533

GinoPane opened this issue Mar 15, 2021 · 1 comment

Comments

@GinoPane
Copy link
Contributor

  • OctoberCMS Build: 471
  • PHP Version: 7.2.4

Description:

When using repeater with maxItems=1, repeater does not work correctly. It adds one record and still shows the button to add one more. When you remove all records and start adding them again, the repeater works as expected.

Steps To Reproduce:

october

@daftspunk
Copy link
Member

Hi @GinoPane, I have tested this and confirm it will be fixed in the upcoming release (available soon). Thanks for the report and for using October CMS! 🙏

If you find it still occurs after updating, just ping me and we can reopen this issue. My testing was with the Test Plugin using the Countries > Related repeater and setting maxItems: 1

  • plugins\october\test\models\country\fields.yaml

It would be worthwhile testing this yourself to ensure we are using the same test conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants