Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AwsAcmMangingProcessor can't be referenced #1

Closed
gaston-te opened this issue Jan 11, 2022 · 2 comments · Fixed by #2
Closed

AwsAcmMangingProcessor can't be referenced #1

gaston-te opened this issue Jan 11, 2022 · 2 comments · Fixed by #2

Comments

@gaston-te
Copy link

I'm not sure if this is the only piece missing, but the setup.py in this module should be using the same find_packages() function as in the main octodns repository here

Without this, octodns_route53.processor is missing from the packages and therefore can't be referenced for usage.
@gaston-te
Copy link
Author

cc' @ross Ross McFarland on this issue

@ross
Copy link
Contributor

ross commented Jan 11, 2022

Weird, I would have thought if it found the main __init__.py it'd also be including anything else under the module. Will get a PR going shortly.

This was referenced Jan 11, 2022
Merged
Merged
@ross ross closed this as completed in #2 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use find_packages so that everything is found, not just the top-level octodns/octodns-route53
2 participants
@ross @gaston-te