Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use text_matrix and test jobs #225

Closed
gr2m opened this issue Jul 8, 2022 · 1 comment · Fixed by #226
Closed

ci: use text_matrix and test jobs #225

gr2m opened this issue Jul 8, 2022 · 1 comment · Fixed by #226
Assignees
@oscard0m

Comments

@gr2m
Copy link
Contributor

gr2m commented Jul 8, 2022

Follow up to #221

Ideally we would do a test_matrix step and then a test step that depends on test_matrix, so that for branch protections we can require test independent of the Node versions we are using.

See this for reference: https://github.com/octokit/core.js/blob/393caf31b2e802ea9be59aa84f90d64f98953fdb/.github/workflows/test.yml#L32
@oscard0m oscard0m mentioned this issue Jul 9, 2022
Merged
@oscard0m oscard0m self-assigned this Jul 9, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscard0m oscard0m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(test): use text_matrix and test jobs octokit/auth-action.js
2 participants
@gr2m @oscard0m