Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT]: npm run build is failing #247

Closed
1 task done
gr2m opened this issue Jun 11, 2024 · 2 comments · Fixed by #248
Closed
1 task done

[MAINT]: npm run build is failing #247

gr2m opened this issue Jun 11, 2024 · 2 comments · Fixed by #248
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@gr2m
Copy link
Contributor

gr2m commented Jun 11, 2024

Describe the need

see https://github.com/octokit/auth-callback.js/actions/runs/9470231822/job/26090632310

@wolfy1339 I think you did the update to the build scripts across @octokit. Does that one ring any bells?

SDK Version

No response

API Version

No response

Relevant log output

Run npm run build

> @octokit/auth-callback@0.0.0-development build
> node scripts/build.mjs && tsc -p tsconfig.json

Error: src/auth.ts(3,1): error TS1287: A top-level 'export' modifier cannot be used on value declarations in a CommonJS module when 'verbatimModuleSyntax' is enabled.
Error: src/hook.ts(11,10): error TS1286: ESM syntax is not allowed in a CommonJS module when 'verbatimModuleSyntax' is enabled.
Error: src/hook.ts(13,1): error TS1287: A top-level 'export' modifier cannot be used on value declarations in a CommonJS module when 'verbatimModuleSyntax' is enabled.
Error: src/index.ts(1,10): error TS1286: ESM syntax is not allowed in a CommonJS module when 'verbatimModuleSyntax' is enabled.
Error: src/index.ts(2,10): error TS1286: ESM syntax is not allowed in a CommonJS module when 'verbatimModuleSyntax' is enabled.
Error: src/index.ts(15,1): error TS1287: A top-level 'export' modifier cannot be used on value declarations in a CommonJS module when 'verbatimModuleSyntax' is enabled.
Error: src/types.ts(1,13): error TS1286: ESM syntax is not allowed in a CommonJS module when 'verbatimModuleSyntax' is enabled.
Error: src/with-authorization-prefix.ts(6,1): error TS1287: A top-level 'export' modifier cannot be used on value declarations in a CommonJS module when 'verbatimModuleSyntax' is enabled.
Error: Process completed with exit code 2.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@gr2m gr2m added Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Jun 11, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

Ah, yes, this package wasn't migrated to ESM, and the @octokit/tsconfig version was bumped to the one for ESM

@wolfy1339 wolfy1339 removed the Status: Triage This is being looked at and prioritized label Jun 11, 2024
@gr2m gr2m closed this as completed in #248 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants