Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade @octokit/app #2460

Merged
merged 1 commit into from
May 27, 2023
Merged

fix(deps): upgrade @octokit/app #2460

merged 1 commit into from
May 27, 2023

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented May 27, 2023

Propogate octokit/app.js#422 to the octokit package to alleviate CDN caching issues

Resolves part of #2450


Behavior

Before the change?

  • Users that are consuming this package via a CDN were getting a bad version of @octokit/auth-app

After the change?

  • Upgrades @octokit/app to make sure that that dependency is a good version

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Dependencies/code cleanup: Type: Maintenance

Propogate octokit/app.js#422 to the `octokit` package to alleviate CDN caching issues
@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label May 27, 2023
@ghost ghost added this to Bugs in JS May 27, 2023
@wolfy1339 wolfy1339 marked this pull request as ready for review May 27, 2023 01:43
@gr2m gr2m merged commit 4db2da3 into main May 27, 2023
9 checks passed
JS automation moved this from Bugs to Done May 27, 2023
@gr2m gr2m deleted the upgrade-app.js branch May 27, 2023 01:46
@github-actions
Copy link

🎉 This PR is included in version 2.0.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

wolfy1339 added a commit that referenced this pull request Jun 3, 2023
* fix(deps): upgrade `@octokit/app` (#2460)

Propogate octokit/app.js#422 to the `octokit` package to alleviate CDN caching issues

* build(deps): lock file maintenance

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @octokit/plugin-retry to v5

---------

Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@github-actions
Copy link

🎉 This PR is included in version 3.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @beta released Type: Bug Something isn't working as documented
Projects
Archived in project
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants