Skip to content

Commit

Permalink
[BUG] Fix Deserializing WorkflowJob (#2725)
Browse files Browse the repository at this point in the history
make some fields nullable on workflowjob
  • Loading branch information
lineville committed Jun 16, 2023
1 parent da5c4d7 commit e1d587b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Octokit/Models/Response/WorkflowJob.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public class WorkflowJob
{
public WorkflowJob() { }

public WorkflowJob(long id, long runId, string runUrl, string nodeId, string headSha, string url, string htmlUrl, WorkflowJobStatus status, WorkflowJobConclusion? conclusion, DateTimeOffset startedAt, DateTimeOffset? completedAt, string name, IReadOnlyList<WorkflowJobStep> steps, string checkRunUrl, IReadOnlyList<string> labels, long runnerId, string runnerName, long runnerGroupId, string runnerGroupName)
public WorkflowJob(long id, long runId, string runUrl, string nodeId, string headSha, string url, string htmlUrl, WorkflowJobStatus status, WorkflowJobConclusion? conclusion, DateTimeOffset startedAt, DateTimeOffset? completedAt, string name, IReadOnlyList<WorkflowJobStep> steps, string checkRunUrl, IReadOnlyList<string> labels, long? runnerId = default, string runnerName = default, long? runnerGroupId = default, string runnerGroupName = default)
{
Id = id;
RunId = runId;
Expand Down Expand Up @@ -111,7 +111,7 @@ public WorkflowJob(long id, long runId, string runUrl, string nodeId, string hea
/// <summary>
/// The Id of the runner to which this job has been assigned.
/// </summary>
public long RunnerId { get; private set; }
public long? RunnerId { get; private set; }

/// <summary>
/// The name of the runner to which this job has been assigned.
Expand All @@ -121,7 +121,7 @@ public WorkflowJob(long id, long runId, string runUrl, string nodeId, string hea
/// <summary>
/// The Id of the runner group to which this job has been assigned.
/// </summary>
public long RunnerGroupId { get; private set; }
public long? RunnerGroupId { get; private set; }

/// <summary>
/// The name of the runner group to which this job has been assigned.
Expand Down

0 comments on commit e1d587b

Please sign in to comment.