Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix Deserializing WorkflowJob #2725

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

lineville
Copy link
Contributor

@lineville lineville commented Jun 9, 2023

Resolves #2724 by making the following fields nullable: RunnerId, RunnerName, RunnerGroupId, RunnerGroupName which may be null when the WorkflowJob is coming from a WorkflowJobEvent webhook.


Behavior

Before the change?

  • Deserializing a WorkflowJob that was received from a WorkflowJobEvent webhook would fail if any of the non-nullable fields we're null.

After the change?

  • Deserializing a WorkflowJob that was received from a WorkflowJobEvent webhook succeeds even if it has null values for the 4 fields mentioned above.

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@lineville lineville changed the title [BUG} Fix Deserializing WorkflowJob [BUG] Fix Deserializing WorkflowJob Jun 9, 2023
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lineville!

@kfcampbell kfcampbell merged commit e1d587b into octokit:main Jun 16, 2023
5 checks passed
@lineville lineville deleted the fix-workflowjob-model branch June 16, 2023 20:32
@lineville
Copy link
Contributor Author

@kfcampbell Any plans to cut a release anytime soon 😄 ? Is there a plan to try to land a few more PRs before cutting a release? Thanks again for the quick turn around approving and merging this! ♥️

@kfcampbell
Copy link
Member

@lineville I've released v6.1.0; please let me know if your changes aren't properly reflected in that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Deserializing WorkflowJob from WorkflowJobEvent webhooks fails
2 participants