Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response models should be readonly #650

Closed
haacked opened this issue Dec 31, 2014 · 1 comment · Fixed by #658
Closed

Response models should be readonly #650

haacked opened this issue Dec 31, 2014 · 1 comment · Fixed by #658

Comments

@haacked
Copy link
Contributor

haacked commented Dec 31, 2014

It's bothered me that our response models are mutable. They really shouldn't be. Now that I've dug into the serialization code a bit, I think we can make our models have readonly properties. Right now, I'm planning to make the properties have a protected setter instead of private to provide flexibility for others who might be deriving from these classes or testing them.

Let me know what you think. I'll have a PR ready soon-ish. This depends on the work I did in #649
@shiftkey
Copy link
Member

haacked added a commit that referenced this issue Jan 2, 2015
@haacked
Make response models readonly
22c03b8 
It's bothered me that our response models are mutable. They really
shouldn't be. I made the properties have a protected setter instead of
private to provide flexibility for others who might be deriving from
these classes or testing them.

Fixes #650
haacked added a commit that referenced this issue Jan 2, 2015
@haacked
Make repositoryContent readonly
fb08e01 
Fixes #650
@haacked haacked mentioned this issue Jan 2, 2015
Merged
khellang added a commit to khellang/octokit.net that referenced this issue Jan 2, 2015
@khellang
Made property setters protected to address octokit#650
47a2aba
@khellang khellang mentioned this issue Jan 2, 2015
Merged
haacked added a commit that referenced this issue Jan 4, 2015
@haacked
Make response models readonly
9f67592 
It's bothered me that our response models are mutable. They really
shouldn't be. I made the properties have a protected setter instead of
private to provide flexibility for others who might be deriving from
these classes or testing them.

Fixes #650
haacked added a commit that referenced this issue Jan 4, 2015
@haacked
Make repositoryContent readonly
0e25b14 
Fixes #650
khellang added a commit to khellang/octokit.net that referenced this issue Jan 4, 2015
@khellang
Made property setters protected to address octokit#650
54db7ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Readonly response models octokit/octokit.net
2 participants
@haacked @shiftkey