Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Add Author To Release Response #1009

Merged
merged 3 commits into from
Dec 16, 2015
Merged

Fixed Add Author To Release Response #1009

merged 3 commits into from
Dec 16, 2015

Conversation

gabrielweyer
Copy link
Contributor

Fixes #1008

Added Author to Release response. Added integration test ensuring login is set on Author property.

I noticed that some other properties are missing too:

  • assets (this is an object)
  • tarball_url
  • zipball_url

Do we want to add those too?

Sample response:

{
    "url": "https://api.github.com/repos/git-tfs/git-tfs/releases/2276624",
    "assets_url": "https://api.github.com/repos/git-tfs/git-tfs/releases/2276624/assets",
    "upload_url": "https://uploads.github.com/repos/git-tfs/git-tfs/releases/2276624/assets{?name,label}",
    "html_url": "https://github.com/git-tfs/git-tfs/releases/tag/v0.24.1",
    "id": 2276624,
    "tag_name": "v0.24.1",
    "target_commitish": "master",
    "name": "",
    "draft": false,
    "author": {
        "login": "spraints",
        "id": 20158,
        "avatar_url": "https://avatars.githubusercontent.com/u/20158?v=3",
        "gravatar_id": "",
        "url": "https://api.github.com/users/spraints",
        "html_url": "https://github.com/spraints",
        "followers_url": "https://api.github.com/users/spraints/followers",
        "following_url": "https://api.github.com/users/spraints/following{/other_user}",
        "gists_url": "https://api.github.com/users/spraints/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/spraints/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/spraints/subscriptions",
        "organizations_url": "https://api.github.com/users/spraints/orgs",
        "repos_url": "https://api.github.com/users/spraints/repos",
        "events_url": "https://api.github.com/users/spraints/events{/privacy}",
        "received_events_url": "https://api.github.com/users/spraints/received_events",
        "type": "User",
        "site_admin": true
    },
    "prerelease": false,
    "created_at": "2015-12-12T03:10:45Z",
    "published_at": "2015-12-12T03:12:47Z",
    "assets": [
        {
            "url": "https://api.github.com/repos/git-tfs/git-tfs/releases/assets/1121275",
            "id": 1121275,
            "name": "GitTfs-0.24.1.zip",
            "label": null,
            "uploader": {
                "login": "spraints",
                "id": 20158,
                "avatar_url": "https://avatars.githubusercontent.com/u/20158?v=3",
                "gravatar_id": "",
                "url": "https://api.github.com/users/spraints",
                "html_url": "https://github.com/spraints",
                "followers_url": "https://api.github.com/users/spraints/followers",
                "following_url": "https://api.github.com/users/spraints/following{/other_user}",
                "gists_url": "https://api.github.com/users/spraints/gists{/gist_id}",
                "starred_url": "https://api.github.com/users/spraints/starred{/owner}{/repo}",
                "subscriptions_url": "https://api.github.com/users/spraints/subscriptions",
                "organizations_url": "https://api.github.com/users/spraints/orgs",
                "repos_url": "https://api.github.com/users/spraints/repos",
                "events_url": "https://api.github.com/users/spraints/events{/privacy}",
                "received_events_url": "https://api.github.com/users/spraints/received_events",
                "type": "User",
                "site_admin": true
            },
            "content_type": "application/zip",
            "state": "uploaded",
            "size": 8703010,
            "download_count": 148,
            "created_at": "2015-12-12T03:15:42Z",
            "updated_at": "2015-12-12T03:15:57Z",
            "browser_download_url": "https://github.com/git-tfs/git-tfs/releases/download/v0.24.1/GitTfs-0.24.1.zip"
        }
    ],
    "tarball_url": "https://api.github.com/repos/git-tfs/git-tfs/tarball/v0.24.1",
    "zipball_url": "https://api.github.com/repos/git-tfs/git-tfs/zipball/v0.24.1",
    "body": "* Fix problems with 0.24.0 (#886, #887)\r\n"
}

@shiftkey
Copy link
Member

Do we want to add those too?

Sure!

@gabrielweyer
Copy link
Contributor Author

Added everything that was missing. Left out gravatar_id from the user payload as it has been deprecated.

@gabrielweyer
Copy link
Contributor Author

I didn't run the build script locally, I'm a bad man 😰

@shiftkey
Copy link
Member

I didn't run the build script locally, I'm a bad man 😰

@haacked
Copy link
Contributor

haacked commented Dec 16, 2015

Looks good to me!

selfie-1

haacked added a commit that referenced this pull request Dec 16, 2015
Fixed Add Author To Release Response
@haacked haacked merged commit 439b058 into octokit:master Dec 16, 2015
@gabrielweyer gabrielweyer deleted the release-author branch December 17, 2015 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants