Added missing fields from API and removed fields that are not returned by API #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to use the property |
I'm tentatively 👍 on this, but I'll let @haacked throw his 2c in as well before we close this out. |
|
Looks good to me. Thanks! |
haacked
added a commit
that referenced
this pull request
Jan 2, 2016
Added missing fields from API and removed fields that are not returned by API
|
GitHub webhooks are triggered on assignment and labeling and have indeed Label and Assignee property when applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Also has an
IdandLockedproperties. I tested the change in theCanDeserializeIssuemethod.IssueEventPayload
Doesn't have a property
AssigneeorLabel. GitHub only fire an event when an issue is opened, closed or re-opened. GitHub does not fire an event when assigning someone to the issue, assigning a label or a milestone (I tested manually on my test repository).IssueEvents
Has a
CommitUrlproperty. I tested the change in theCanDeserializeMergedEventmethod.Note: the documentation doesn't have the
CommitUrlproperty yet but it is being returned by the API (I usedFiddleras my proxy to inspect what was returned).