Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to dotnet-format tool #2016

Merged
merged 2 commits into from
Sep 24, 2019
Merged

migrate to dotnet-format tool #2016

merged 2 commits into from
Sep 24, 2019

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Sep 24, 2019

Back in the day I added shiftkey/Octokit.CodeFormatter to this project, but that predates the global tools support for .NET Core. I had a look around today before I took a shot at updating it and found dotnet-format has shipped, so I'm going to retire that in favour of this.

This PR now adds in the FormatCode step as a local build (so devs can run ./build.ps1 or ./build.sh and have their code tidied up for free) and tidies up what is currently on master.

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #2016 into master will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master    #2016   +/-   ##
=======================================
  Coverage   70.77%   70.77%           
=======================================
  Files         535      535           
  Lines       14062    14062           
=======================================
  Hits         9952     9952           
  Misses       4110     4110
Impacted Files Coverage Δ
...Clients/PullRequestReviewCommentReactionsClient.cs 100% <ø> (ø) ⬆️
...e/Clients/ObservableIssueCommentReactionsClient.cs 100% <ø> (ø) ⬆️
Octokit/Models/Request/NewPullRequest.cs 73.33% <ø> (ø) ⬆️
...kit.Reactive/Clients/ObservableMigrationsClient.cs 100% <ø> (ø) ⬆️
Octokit/Clients/IssueCommentsClient.cs 91.42% <ø> (ø) ⬆️
...servablePullRequestReviewCommentReactionsClient.cs 100% <ø> (ø) ⬆️
Octokit/Models/Response/PullRequest.cs 12.5% <ø> (ø) ⬆️
Octokit/Clients/IssueCommentReactionsClient.cs 100% <ø> (ø) ⬆️
...Reactive/Clients/ObservableIssueReactionsClient.cs 100% <ø> (ø) ⬆️
Octokit/Models/Response/Milestone.cs 43.24% <ø> (ø) ⬆️
... and 2 more

@shiftkey shiftkey merged commit ce5ea64 into master Sep 24, 2019
@shiftkey shiftkey deleted the migrate-to-dotnet-format branch September 24, 2019 14:35
@shiftkey
Copy link
Member Author

shiftkey commented Oct 3, 2019

release_notes: migrated from custom formatter to using dotnet-format

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants