Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev container rework to support OmniSharp changes #2456

Merged
merged 7 commits into from
Jun 10, 2022
Merged

Conversation

nickfloyd
Copy link
Contributor

These changes are needed so that when working on code spaces and on OmniSharp server will properly start - https://github.com/OmniSharp/omnisharp-vscode#requirements

@nickfloyd nickfloyd requested a review from timrogers June 9, 2022 22:04
@nickfloyd nickfloyd marked this pull request as ready for review June 9, 2022 22:04
@timrogers
Copy link
Contributor

Does Omnisharp start for you with these changes? It doesn't for me. If I try to run the 'Restart OmniSharp' command for the command palette, I also get an error like this:
Screenshot 2022-06-10 at 11 31 58

@nickfloyd
Copy link
Contributor Author

nickfloyd commented Jun 10, 2022

Does Omnisharp start for you with these changes? It doesn't for me. If I try to run the 'Restart OmniSharp' command for the command palette, I also get an error like this.

Yes it starts right away. Odd I've never seen that error. I am assuming steps to repro are:

  1. Spin up a code space using this branch
  2. Restart OmniSharp.

Validate my assumed steps to repo - perhaps we can pair on it as well some time.

@timrogers
Copy link
Contributor

Does Omnisharp start for you with these changes? It doesn't for me. If I try to run the 'Restart OmniSharp' command for the command palette, I also get an error like this.

Yes it starts right away. Odd I've never seen that error. I am assuming steps to repro are:

  1. Spin up a code space using this branch
  2. Restart OmniSharp.

Validate my assumed steps to repo - perhaps we can pair on it as well some time.

Exactly. I did that, and that's what I'm seeing. Also worth noting that IntelliSense etc. doesn't work for me.

@timrogers
Copy link
Contributor

I just ran the command because I saw IntelliSense wasn't working and I thought it might help. It seems that all the OmniSharp related commands generated similar errors.

@nickfloyd
Copy link
Contributor Author

nickfloyd commented Jun 10, 2022

I just ran the command because I saw IntelliSense wasn't working and I thought it might help. It seems that all the OmniSharp related commands generated similar errors.

Interesting... Would you mind sharing what you are seeing in the VS Code "Output" window after the code space is generated?

Generally, you'll see something like, or a OmniSharp "service has started...." :
Screen Shot 2022-06-10 at 9 17 29 AM

Thanks for your help and 👀 on this btw... I'd really like to get this DX solid for all contributors.

@nickfloyd nickfloyd self-assigned this Jun 10, 2022
Copy link
Contributor

@timrogers timrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restarted my container and it worked 🤔 What do you think of merging this, and coming back later if we or others run into issues?

@nickfloyd nickfloyd merged commit bfdcb18 into main Jun 10, 2022
@nickfloyd nickfloyd deleted the devcontainer-rework branch June 10, 2022 15:35
@nickfloyd
Copy link
Contributor Author

release_notes: Adds support to the dev container for OmniSharp

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR Type: Feature New feature or request and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants