added support for ref value in get contents api #730
Conversation
| /// <returns> | ||
| /// A collection of <see cref="RepositoryContent"/> representing the content at the specified path | ||
| /// </returns> | ||
| public async Task<IReadOnlyList<RepositoryContent>> GetContents(string owner, string name, string path, string reference) |
There was a problem hiding this comment.
Because we maintain an set of IObservable<T> APIs that mirror this, the build server is currently complaining.
To fix this, you'll need to add the new method to IObservableRepositoryContentsClient and implement it over there too.
|
Would it be possible to add some tests for this? I'm not sure how valuable it'd be to target references that might be transient, but look at the integration tests in |
goalie7960
force-pushed
the
get-contents-api
branch
from
fe74d7a
to
e292a05
Compare
| /// <returns> | ||
| /// A collection of <see cref="RepositoryContent"/> representing the content at the specified path | ||
| /// </returns> | ||
| IObservable<IReadOnlyList<RepositoryContent>> GetContents(string owner, string name, string path, string reference); |
There was a problem hiding this comment.
This should be IObservable<RepositoryContent>
|
going to close this, will reopen when i'm ready |
| /// <returns> | ||
| /// A collection of <see cref="RepositoryContent"/> representing the content at the specified path | ||
| /// </returns> | ||
| Task<IReadOnlyList<RepositoryContent>> GetContents(string owner, string name, string path, string reference); |
There was a problem hiding this comment.
In #771 we added a rule to the test suite to ensure all methods which returned a IReadOnlyList<T> were named with the prefix GetAll - if you update this name and the related observable method name you should be ✨
added support for ref value in get contents api
|
|
as far as i could tell, it was impossible to specify the ref parameter on the get contents api method https://developer.github.com/v3/repos/contents/#get-content