adding missing organization teams APIs #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was done because the same Uri is also used to get a team, not just updating and deleting. - Fixed references pointing to method name that was changed.
- Implemented the aforementioned Get method in the Octokit/Clients/TeamsClient class. - Added test in Octokit.Tests/Clients/TeamsClientTests for the aforementioned Get method.
interface. - Implemented aforementioned Get method in Octokit.Reactive/Clients/ObservableTeamsClient class.
…-org-teams Conflicts: Octokit.Reactive/Clients/IObservableTeamsClient.cs Octokit.Reactive/Clients/ObservableTeamsClient.cs Octokit/Clients/ITeamsClient.cs Octokit/Clients/TeamsClient.cs Octokit/Helpers/ApiUrls.cs
- Added functionality for AddMember, RemoveMember and GetRepositories - Unit tests missing for now.
- Removed generic ApiException exception from xml-doc on Teams related client methods. - Added ApiValidationException exception in xml-doc for AddMember team client method.
Added AddMember and Remove Member tests.
- Added test for GetRepositories method. - Updated todo's on other tests for the teams client.
- Added teams client interface methods for AddRepository, RemoveRepository and IsRepositoryManagedByTeam. - Added Uri for the aforementioned methods.
- AddRepository - RemoveRepository - IsRepositoryManagedByTeam
In both the ObservableTeamsClient and TeamsClient, added: - AddRepository - RemoveRepository - IsRepositoryManagedByTeam
Added tests to ensure non null or empty arguments for the AddRepository, RemoveRepository and IsRepositoryManagedByTeam methods in the teams client. Also included todo's for adding tests to check if methods request the correct url and also return correct results.
…tomtypist/octokit.net into phantomtypist-phantomtypist/331-org-teams Conflicts: Octokit.Reactive/Clients/IObservableTeamsClient.cs Octokit.Reactive/Clients/ObservableTeamsClient.cs Octokit.Tests/Clients/TeamsClientTests.cs Octokit/Clients/ITeamsClient.cs Octokit/Clients/TeamsClient.cs Octokit/Helpers/ApiUrls.cs
Conflicts: Octokit.Tests/Clients/TeamsClientTests.cs
|
I've marked Everything else is new APIs. Ready for review. |
shiftkey
changed the title
shiftkey
changed the title
haacked
added a commit
that referenced
this pull request
Jun 12, 2015
adding missing organization teams APIs
This was referenced Jun 16, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @phantomtypist for starting this off.
http://developer.github.com/v3/orgs/teams/#get-team-memberto be deprecated, use https://developer.github.com/v3/orgs/teams/#get-team-membershiphttp://developer.github.com/v3/orgs/teams/#add-team-memberto be deprecated, use https://developer.github.com/v3/orgs/teams/#add-team-membershiphttp://developer.github.com/v3/orgs/teams/#remove-team-memberto be deprecated, use https://developer.github.com/v3/orgs/teams/#remove-team-membership