Add SHA and make message optional for pull request merge #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shiftkey
added a commit
that referenced
this pull request
May 19, 2015
Add SHA and make message optional for pull request merge
|
|
😀
| /// <summary> | ||
| /// The message that will be used for the merge commit (optional) | ||
| /// </summary> | ||
| public string Message { get; private set; } | ||
| public string Message { get; set; } |
There was a problem hiding this comment.
I'm currently fixing this, but according to the docs here: https://developer.github.com/v3/pulls/#merge-a-pull-request-merge-button
This is not optional and it should be CommitMessage. Did you happen to see something that suggests otherwise?
There was a problem hiding this comment.
I would've thought I did see something that suggested that the Message property was optional, but can't for the life of me remember (or find) where.
There was a problem hiding this comment.
Well the response is message but the request is commit_message. The docs are actually a bit unclear on this so I'll ask @pengwynn for clarification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #804