Fixes for Downloading ReleaseAsset zip File #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addressed the `BuildResponse` wasn't handling response `content-type` `application/octet-stream` for binary items.
| // Let's constrain this appropriately. | ||
| var binaryContentTypes = new[] {"application/zip" | ||
| ,"application/x-gzip", | ||
| "application/octet-stream"}; |
There was a problem hiding this comment.
I don't know if the response content type could be anything else other than application/octet-stream. From the test's that I have done with API for zip and txt the response content type has only been application/octet-stream. Do we need the other types?
There was a problem hiding this comment.
I wouldn't worry about other types here...
Fixed the spacing of comma and aligned the arguments.
|
I think this is good to go. @haacked? |
haacked
added a commit
that referenced
this pull request
Oct 29, 2015
Fixes for Downloading ReleaseAsset zip File
|
Awww yeah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the http response which wasn't handling response
content-typeapplication/octet-streamfor binary items.Fixes #854