Implemented personal token authorization creation #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecify an app clientid/clientsecret. These methods will ONLY work with username/password Basic Auth. Added a helper method to return a GitHub client using basic auth credentials as if you have both password and oauth token environment variables, you get credentials based on the oauth token.
| Ensure.ArgumentNotNull(newAuthorization, "authorization"); | ||
|
|
||
| return _client.Create(newAuthorization).ToObservable(); | ||
|
|
There was a problem hiding this comment.
This PR is perfect so I'm going to nitpick on the extraneous line endings between the return statement and closing brace. 😛
|
Nicely done! The only issue I had is with the white space formatting. |
|
D'Oh, white space! |
|
Whitespace gone the way of the dodo 😊 |
|
Thanks @alfhenrik! |
shiftkey
added a commit
that referenced
this pull request
Dec 11, 2015
Implemented personal token authorization creation
|
Thank you guys! |
No! THANK YOU HENRIK! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented methods for creating an authorization without having to specify an app clientid/clientsecret.
These methods will ONLY work with username/password Basic Auth.
Added a helper method to return a GitHub client using basic auth credentials as if you have both password and oauth token environment variables, you get credentials based on the oauth token.
Fixes #969