Add support for Milestones in API version 3 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
catsby
commented
May 6, 2011
catsby
commented
- List all milestones
- List a single milestone
- Create milestone
- Delete a single milestone
- add test - Documentation for `list_milestones`
- Test included - Fixture for single milestone
- Test included
If using API V3: - Use Faraday::Request::JSON instead of Faraday::Request::UrlEncoded - Set request.body with options.to_json since V3 expects JSON (see http://developer.github.com/v3/#schema ) Pass `version` up to `connection` method call, since we need to do version checking in that method now for JSON/UrlEncoded switch. Moved `url` setup to `connection` as well, just to keep the checks against version number in a consistant place
+ test
|
This looks awesome! |
sferik
added a commit
that referenced
this pull request
May 6, 2011
Add support for Milestones in API version 3
|
I just noticed the update method was missing. Were you not able to get PATCH working? |
|
Ugh, slipped my mind when I was figuring out the JSON encoding issue I was having. I'll take a look in the morning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.