Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to populate the review request with users #890

Closed
wants to merge 2 commits into from

Conversation

jblac
Copy link

@jblac jblac commented May 15, 2017

I had the need to automatically assign review_requests when users missed it, in order to do that I added that one method to the client.

Not sure how to properly do a spec for this so I did leave that out if this is of interest to the maintainer(s).

@coveralls
Copy link

coveralls commented May 15, 2017

Coverage Status

Coverage decreased (-0.02%) to 99.245% when pulling 6b86216 on jblac:create-review-requests into 493dc91 on octokit:master.

@kytrinyx
Copy link
Contributor

Hey! This looks pretty good. There are a couple of things we'd need in order to merge it.

  1. The endpoint requires a preview media type (see: https://developer.github.com/v3/pulls/review_requests/#create-a-review-request)
  2. We're going to need tests.

You can check out this PR for guidance on how to do these things: #928

@jblac
Copy link
Author

jblac commented Sep 14, 2017

@kytrinyx thanks for that info, I'll get this pr updated asap with the necessary elements.

@tarebyte
Copy link
Member

Gentle bump @jblac are you still interested in taking this over the finish line?

@tarebyte tarebyte changed the base branch from master to 4-stable October 19, 2020 18:38
@nickfloyd
Copy link
Contributor

Hey, @jblac thank you for the effort here. Given this has been out for close to 5 years and many changes have been added since this was first introduced, I am going to close this PR and mark it as stale. If you feel strongly about this needing to be implemented please feel free to reopen and make the changes stated above and we'll do what we can to get it merged in. Thanks again!

@nickfloyd nickfloyd closed this May 24, 2022
@nickfloyd nickfloyd added Status: Stale Used by stalebot to clean house and removed stale labels Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Used by stalebot to clean house
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants