Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index.d.ts missing standalone functionality #152

Closed
SpencerKaiser opened this issue Jun 6, 2020 · 4 comments · Fixed by #153
Closed

index.d.ts missing standalone functionality #152

SpencerKaiser opened this issue Jun 6, 2020 · 4 comments · Fixed by #153

Comments

@SpencerKaiser
Copy link
Contributor

index.d.ts is missing exports for several items that the README specifies as something that can be used standalone: verify, sign, and middleware
@SpencerKaiser SpencerKaiser mentioned this issue Jun 6, 2020
Open
1 task
@gr2m
Copy link
Contributor

gr2m commented Jun 6, 2020

@dominguezcelada could you check that out?

@oscard0m
Copy link
Member

oscard0m commented Jun 6, 2020

@dominguezcelada could you check that out?

Sure! Let me take a look.

@oscard0m
Copy link
Member

oscard0m commented Jun 7, 2020

index.d.ts is missing exports for several items that the README specifies as something that can be used standalone: verify, sign, and middleware

As @SpencerKaiser pointed, when the migration to named exports was done, index.d.ts was not updated properly to add support for the new API. I'm going to open a PR for this.

Thanks for pointing it out @SpencerKaiser :)

@oscard0m oscard0m mentioned this issue Jun 7, 2020
Merged
@gr2m gr2m closed this as completed in #153 Jun 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2020

🎉 This issue has been resolved in version 7.6.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 fix(type-declaration): add missing new named exports to generated types (index.d.ts): sign, verif
3 participants
@gr2m @oscard0m @SpencerKaiser